Skip to content

ref(nextjs): Simplify isBuild logic #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 5, 2023
Merged

ref(nextjs): Simplify isBuild logic #6594

merged 5 commits into from
Jan 5, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Dec 21, 2022

With the removal of instrumentServer in #6592 we have no more calls to isBuild() that happen before process.env.NEXT_PHASE is set by Next.js so we can simplify the logic of that function.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.45 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.99 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.39 KB (0%)
@sentry/browser - Webpack (minified) 66.63 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.41 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.68 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.99 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.24 KB (0%)

@lforst lforst changed the title ref(nextjs): Remove instrumentSever ref(nextjs): Simplify isBuild logic Dec 21, 2022
@lforst lforst marked this pull request as ready for review January 3, 2023 15:18
@lforst lforst requested review from mydea, AbhiPrasad and Lms24 January 3, 2023 15:18
mydea
mydea approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing code is great! :D

Lms24
Lms24 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

@lforst lforst self-assigned this Jan 4, 2023
Base automatically changed from lforst-remove-instrument-server to master January 5, 2023 14:32
@lforst lforst merged commit 46a4c3c into master Jan 5, 2023
@lforst lforst deleted the lforst-simplify-isbuild branch January 5, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@lforst lforst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lforst @mydea @Lms24